requirements: pin universal2 binaries for PyInstaller (bug 1855547) #1476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzzeid
force-pushed
the
zeid/bug-1855547-universal2-pip
branch
from
813ca21 to
ad22fc2
Compare
cgsheeh
requested changes
Sep 28, 2023
cgsheeh
requested changes
Sep 28, 2023
zzzeid
force-pushed
the
zeid/bug-1855547-universal2-pip
branch
from
523ac7e to
c85ed07
Compare
cgsheeh
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the updated requirements at this time prevent PyInstaller from being able to build a universal2 binary for macOS, because pip may choose a more specific wheel when installing packages on CI. Currently, the only way to force a universal2 wheel is to specify it by filename. See pypa/pip#11573 for more on this.